I wanted a way to quickly edit the page when I was on it, so i just added this simple bit of code in to my template. Place where ever it is convenient for you, but it only shows when you are logged in. You must have login enabled in prefs, but someone might be able to hack the code further???
<?php
if(FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID'))) {
?><a href="<?php echo ADMIN_URL; ?>/index.php"><?php echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="http://[you-website.domain]/admin/pages/modify.php?page_id=<?php echo $page_id; ?>">Edit Page</a>
<?php
}
?>
simple i know, but useful.
Pete
Very good idea, 1 improvement though, the second url, doens't make use of the ADMIN_URL yet, change to:
<?php
if(FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID'))) {
?><a href="<?php echo ADMIN_URL; ?>/index.php"><?php echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php echo $page_id; ?>">Edit Page</a>
<?php
}
?>
I suggestion, maybe a check to see if the logged in user is admin or has the rights to edit the page??
John
Very handy indeed, good job!
A little improvement, in case you have a multilingual website, you might want to do this:
<?php
if(FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
{
?>
<a href="<?php echo ADMIN_URL; ?>/index.php"><?php echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php echo $page_id; ?>"><?php echo $HEADING['MODIFY_PAGE']; ?></a>
<?php
}
?>
check to see if logged in user is an admin could be done with:
if ($wb->get_session('GROUP_ID')==1)
(i did so and it works fine for me)
Very handy indeed!
I slightly refined it (open new window). Thanks.
Vincent
<?php
if(FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
if ($wb->get_session('GROUP_ID')==1)
{
?>
<a href="<?php echo ADMIN_URL; ?>/index.php"target="_blank"><?php echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php echo $page_id; ?>"target="_blank"><?php echo $HEADING['MODIFY_PAGE']; ?></a>
This works great for me and saves time when tweaking pages.
However, I'm having a problem. This snippet works fine for every page except my 'home' page which happens to be $page_id=1. Has anyone else had a problem using this snippet with $page_id=1? If so, is there a solution?
I love this! This will be really great for some of the folks I build websites for. Thanks!!
I was trying to figure out why my implementation of this didn't work until I realized that I was on Home as well. I guess we'll just have to hardcode IF id="" then ID=1 or whatever your home page code is (mine is 3, must have deleted it twice I guess)
Vincent - good idea, but your code got cut off at the end.
So here's my combined solution!
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
if ($wb->get_session('GROUP_ID')==1)
{
?>
<a href="<?php echo ADMIN_URL; ?>/index.php"><?php
echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php
if ($page_id)
echo $page_id;
else
echo "3";
?>" target="_blank"><?php echo $HEADING['MODIFY_PAGE']; ?></a>
<?php
}
?>
Wow! This hint is SOOO useful!
Is there a way to automatically find out what the id of the home page is without having to hard-code it? I ask because I can imagine some of my clients deleting the home page, making another one, and causing the link to fail.
You mean... like I did? :lol:
That's a good point. You might have to just tell them not to do that, I couldn't figure out another way to do it without mucking into the core further and I didn't have time to do that.
It would be best to integrate this function into the system, and have it as an option on Settings, like Log In and Search.
Actually another thing I've been wanting to try doing is a "view page as guest/member/non-admin" function. I remember seeing that on another CMS and thinking how useful that would be. They implemented it as a fixed administrator menu option. That method sounds like a lot of work for WB.
One quick mod might be to change the Edit Page link to a drop-down listbox with Edit as the first option, and "View as Guest,..." and then display the rest of the types in the Group database. The view link could pass a parameter and a refresh would then automatically bring back the edit/view menu, hopefully. Similar to the template preview function - it can work for one page view, but harder to make it sticky. If it was an available value like the test if you're signed in or not, then you could turn it on and off.
Thank for this 'handy' piece of code.
I'd used something similar in the past for jumping to the ADMIN_URL but the "edit this page" feature is really nice :)
Greetings,
I was using this and made a small modification that makes the link always for the default page when the id changes.
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
if ($wb->get_session('GROUP_ID')==1)
{
?>
<a href="<?php echo ADMIN_URL; ?>/index.php"><?php
echo $TEXT['ADMINISTRATION']; ?></a><br />
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php
if ($page_id)
echo $page_id;
else
echo $wb->default_page_id; ;
?>" target="_blank"><?php echo $HEADING['MODIFY_PAGE']; ?></a>
<?php
}
?>
Notice the use of $wb->default_page_id.
Hope this helps!
Sincerely,
Dustin Lambert
So that's how it's done.
Thanks for that info - good job, Dustin!
Dustin, that is great!
I might include that in the upcoming Template Primer - a guide for WB Template Designers.
When I add this code to theme, it won't show... Where else can I add it?
@Mesum: hmmm, hard to know what could be the cause. Here are a few suggestions for you to check and try out:
1) make sure that you are adding the code to the template's 'index.php' file of the template you are currently using in your site.
2) make sure that you are adding the code to a section/element in the BODY of the template, and that it is visible - and not somewhere that is a hidden part of the template's layout.
3) make sure you have 'Login enabled' in your Admin->Settings, and that you login!
AHA! I didn't have 3 on :D Thanks icouto.
Right now, this only works if someone is an admin...
how could this be tweeked to check the admin_groups value in the pages table to see if a user has been enabled as an editor?
I have people who are editors of specific pages. I could hard code this something like...
if ($wb->get_session('GROUP_ID')==1) | ($wb->get_session('GROUP_ID')==3) {
But that only works if the group of editors is editors for every page...
ideally, doing a check of the DB would be slick so it checks and only shows up an edit option if you are authorized to edit that particular page.
Side note to this, I modified it a bit to show the "edit page" icon from the admin panel in the upper right corner of my content area when logged in..
(http://staging.mnmilitia.com/templates/mnmilitia/capture01.png)
<div id="content">
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
if ($wb->get_session('GROUP_ID')==1) {
?>
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php
if ($page_id)
echo $page_id;
else
echo $wb->default_page_id; ;
?>" target="_blank"><img align="right" src="<?php echo ADMIN_URL ?>/images/modify_16.png" alt="<?php echo $HEADING['MODIFY_PAGE']; ?>" /></a>
<?php } ?>
<h2><?php echo MENU_TITLE; ?></h2>
<?php page_content(); ?>
I placed it just inside my content div container, before any other headers or content.
ok, this works... mostly (I looked in the admin/pages/settings.php file to find where it checks permissions)
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
// Get permissons
$database = new database();
$results = $database->query("SELECT * FROM ".TABLE_PREFIX."pages WHERE page_id = '$page_id'");
$results_array = $results->fetchRow();
$old_admin_groups = explode(',', $results_array['admin_groups']);
$old_admin_users = explode(',', $results_array['admin_users']);
$this_user = $wb->get_session('GROUP_ID');
if (is_numeric(array_search($this_user, $old_admin_groups)) ) {
?>
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php
if ($page_id)
echo $page_id;
else
echo $wb->default_page_id; ;
?>" target="_blank"><img align="right" src="<?php echo ADMIN_URL ?>/images/modify_16.png" alt="<?php echo $HEADING['MODIFY_PAGE']; ?>" /></a>
<?php } ?>
But, the icon shows up on any page that doesn't have a specific $page_id, like the default page... even when I'm logged out.. and I'm not sure why.
Check the use of { and } for the nested if's
I don't see a { at the first if and think you need an extra ending } at the last php bit.
Good luck
John
Quote from: pcwacht on June 14, 2007, 09:14:19 PM
Check the use of { and } for the nested if's
I don't see a { at the first if and think you need an extra ending } at the last php bit.
Good luck
John
That did it.. there were actually a couple spots in the original snippet that did not have {}s
here's what I came up with and it seems to be working fine. This does NOT put the link to the admin home page like the original snippet, it puts an image link, right now on the right side (but that can be changed). I placed mine at the top of my content block, just before the page title so it puts the icon across from the title.
You can just as easily include this at the bottom of your content or elsewhere on your page.
I tried to package this as a snippet-module like the RandomImage one but doing so broke things, it did not like the session calls. I may try to fix that eventually... but for now, this checks the permissions for each page, and if someone is logged in, and has permission to edit that particular page, the link shows up. If they don't.. it doesn't show up.
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID'))) {
// Get permissons
if ($page_id) { $this_page = $page_id; }
else { $this_page = $wb->default_page_id; }
$database = new database();
$results = $database->query("SELECT * FROM ".TABLE_PREFIX."pages WHERE page_id = '$this_page'");
$results_array = $results->fetchRow();
$old_admin_groups = explode(',', $results_array['admin_groups']);
$old_admin_users = explode(',', $results_array['admin_users']);
$this_user = $wb->get_session('GROUP_ID');
if (is_numeric(array_search($this_user, $old_admin_groups)) )
{
?>
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=
<?php
if ($page_id) { echo $page_id; }
else { echo $wb->default_page_id; }
?>
" target="_blank"><img align="right" src="<?php echo ADMIN_URL ?>/images/modify_16.png" alt="<?php echo $HEADING['MODIFY_PAGE']; ?>" /></a>
<?php } ?>
<?php } ?>
Ha! Looks like we both had the same ideas. :-)
I ran into issue making a snippet too and stopped work on it.
Guess this will work go enough though - THANKS!
Remember in order for this to work you must have Login enabled.
If you don't have login enabled,
change this:
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID'))) {
to:
if (is_numeric($wb->get_session('USER_ID'))) {
That's a good idea, that way you don't have to have a login page tempting people on every page.
Hmm....
I tried to make a "member tools" page that includes a link to the login page (used the id=#) but it gets a 404? Odd. What's going on here...
There's a system variable for that.. try this..
<a href="<?php echo LOGIN_URL; ?>">member login</a>
I use this to display a link in my templates then is taken from the regular login box, it displays a preferences link, logout link and your name when logged in...
<?php
if(FRONTEND_LOGIN AND !$wb->is_authenticated()) {
?>
<a href="<?php echo LOGIN_URL; ?>">member login</a>
<!-- <a href="<?php echo SIGNUP_URL; ?>">register</a> -->
<?php
} elseif(FRONTEND_LOGIN AND $wb->is_authenticated()) {
?>
<a href="<?php echo PREFERENCES_URL; ?>"><?php echo $MENU['PREFERENCES']; ?></a>
<a href="<?php echo LOGOUT_URL; ?>"><?php echo $MENU['LOGOUT']; ?></a><br />
Logged in as: <span class="caps"><?php echo $wb->get_display_name(); ?></span>
<?php } ?>
Ok, I'm trying to get it so this can be done as a module, but I can't even get it to work as a function...
I put the following in a CODE section on a page...
function edit_this_page()
{
if (is_numeric($wb->get_session('USER_ID')))
{
// Get permissons
if ($page_id) { $this_page = $page_id; }
else { $this_page = $wb->default_page_id; }
$database = new database();
$results = $database->query("SELECT * FROM ".TABLE_PREFIX."pages WHERE page_id = '$this_page'");
$results_array = $results->fetchRow();
$old_admin_groups = explode(',', $results_array['admin_groups']);
$old_admin_users = explode(',', $results_array['admin_users']);
$this_user = $wb->get_session('GROUP_ID');
if (is_numeric(array_search($this_user, $old_admin_groups)) )
{
echo '<a href="'.ADMIN_URL.'/pages/modify.php?page_id=';
if ($page_id) { echo $page_id; }
else { echo $wb->default_page_id; }
echo '" target="_blank"><img align="right" src="'.ADMIN_URL.'/images/modify_16.png" alt="'.$HEADING['MODIFY_PAGE'].' /></a>';
}
}
}
edit_this_page();and I get...
QuoteFatal error: Call to a member function get_session() on a non-object in /home/.elijah/mnpages/baker.mnpages.com/modules/code/view.php(30) : eval()'d code on line 3
Any suggestions?
When using a code section the code will be run through the php interpreter with the function eval();
This is very differrent from using the same code from a module (snippet)
Look at the hello world snippet I once wrote
just replace the echo 'hello world'; with your code and rename the snippet might do just what you need.
Good luck,
John
Thanks to all who worked on this, very handy indeed. I'll echo others by saying it would be great if this were made available eventually as an installable module, but inserting the code into a template isn't too hard... for the time being. :wink:
I found this code snippet pretty need. Took Panthers code and turned it into a snippet modul. Now I am able to use it in a few servers without much additional effort.
For code see
http://forum.WebsiteBaker.org/index.php/topic,8167.0.html
Have fun
Rolf
Hi there, I'm a newcomer in the scene.
I'm very pleased with WB and I have picked up the code snippets about the handy "edit this page" link of which I think it is a great idea.
When using the code in my template, I have had the same problem having the icon being displayed in the "home" condition (page_id = default).
To cope with this I have slightly changed the routine making it check if the group_id is greater than 1, because the group_id of the top_level page is 1 in my case.
The routine now works perfect and I'm very happy with it. Thanks to all of you.
I hope that this subject was still an issue and that I could eventually help someone.
Good luck and best regards,
heikal
[gelöscht durch Administrator]
heilcal,
I'm not sure what you mean. Are you saying you had trouble getting the default (home) page to display the edit icon?
Your code does have the correct code to find it, $wb->default_page_id;
What does it do differently?
I think this will help to make first page editable
if (!isset($page_id)) $page_id = $wb->default_page_id;
<?php
if (FRONTEND_LOGIN == 'enabled' AND is_numeric($wb->get_session('USER_ID')))
// Get permissons
$database = new database();
/* Checking*/ if (!isset($page_id)) $page_id = $wb->default_page_id;
$results = $database->query("SELECT * FROM ".TABLE_PREFIX."pages WHERE page_id = '$page_id'");
$results_array = $results->fetchRow();
$old_admin_groups = explode(',', $results_array['admin_groups']);
$old_admin_users = explode(',', $results_array['admin_users']);
$this_user = $wb->get_session('GROUP_ID');
if (is_numeric(array_search($this_user, $old_admin_groups)) ) {
?>
<a href="<?php echo ADMIN_URL; ?>/pages/modify.php?page_id=<?php
if ($page_id)
echo $page_id;
else
echo $wb->default_page_id; ;
?>" target="_blank"><img align="right" src="<?php echo ADMIN_URL ?>/images/modify_16.png" alt="<?php echo $HEADING['MODIFY_PAGE']; ?>" border="0" /></a><br>
<?php } ?>
This is great. At the moment, it "only" checks if the current user is an admin and them allows editing or not. Can't one change the code such as to check if the current user (or group the user is in) is allowed to edit and then show the icon as well?
THANKS
Mercator
Plc. HELP I can't not get it to work on may page, and do not find any descriptions how do it.
Sorry I am a beginner! :x :?
I have tried what Rolf is writhing in his post 29"; I have also installed his module frontedit.zip. But how and where, shell I but "<?php frontend_edit(); ?>", I have try to edit to template, and puts this string there. I have but this string in to "Resultater - Footer:" and to may font page edit.
Try the snippet module up in post #29 - he wrote instructions in the other thread.
I have tried what Rolf is writhing in his post 29"; I have also installed his module frontedit.zip. But how and where, shell I but "<?php frontend_edit(); ?>", I have try to edit to template, and puts this string there. I have but this string in to "Resultater - Footer:" and to may font page edit. :?
Did you enable front end login?
If so, try to simply add "<?php print "Test"; ?> to prove if there is no error in your template anywhere else.