typo in show_menu2

marmot

Hi,

can confirm. Saw this when patching sm2 for an additonal option here. But it's also obvious that there is no influence on fuctionallity at all.

regards

Martin Hecht

#1
I'm not sure if this is the right place to report, but I have found a pretty obvious typo in show_menu2:
SM2_NO_TITLE should be bit 13 according to the comment, but in fact it is "(bit1 || bit12)" , the following patch corrects this (sorry, I messed up the time stamp of the file):

diff -ru A/modules/show_menu2/include.php B/modules/show_menu2/include.php
--- A/modules/show_menu2/include.php    2014-03-26 07:22:54.372884948 +0100
+++ B/modules/show_menu2/include.php    2014-03-25 22:25:00.025956985 +0100
@@ -38,7 +38,7 @@
define('SM2_CURRTREE',     0x0400); // bit 10
define('SM2_SHOWHIDDEN',   0x0800); // bit 11
define('SM2_XHTML_STRICT', 0x1000); // bit 12
-define('SM2_NO_TITLE',     0x1001); // bit 13
+define('SM2_NO_TITLE',     0x2000); // bit 13

define('_SM2_GROUP_1',  0x000F); // exactly one flag from group 1 is required