Admin panel modification to load one fckeditor at a time plus more section info

[lousou76]

Dear Stefek,

Thanks for the kind words.
No matter how the voting goes, we are surely happy with the result.
I couldn't live without this feature. Other CMSs like joomla etc load one section at the time instead of loading one page with many editors. Loading more than one editor would only make sence if you could save multiple chances at once.

Otherwise it just makes changes a very time consuming process.
I had complains about this from my customers. I couldn't work well in older pc's and I found all these editors useless when the block section had just one image to change.

I guess this speeds things up and even if you don;t like it, you just disable it so everyone is happy.
Let's see how the voting goes.

Regards,
LS

Hello LS.

Thanks for your dedication.

I love this feature. 

Hope mor guys will vote in the next hours.

Regards,
Stefek

[Stefek]

Hello LS.

Thanks for your dedication.

I love this feature. 

Hope mor guys will vote in the next hours.

Regards,
Stefek

[lousou76]

I don't see anyone voting lol

I just finished importing the settings to baker on both 2.7 and svn version as well. (redownload, run the install file and go enable it on the advanced settings page).

It only has the apropriate changes in the english language.
I include an install script to add the extra settings to the db (it doesn't matter how many times you run it).

I 've made the necessary changes to the initial WebsiteBaker script for the svn version, so if you patch first and then install it will work fine and the included install_onefckeditor script is not needed.

My tests show it works fine.

Please check.
Regards,
LS

[lousou76]

Ok Christian thanx.
I 've also changed the layout a bit so the iframes border look nicer.

As I look into it, I can see little changes to the admin/pages/modify.php and no changes to the
modules/wysigg../modify.php so I don;t think there will be a problem there.

I will just have to install the latest trunc to be able to test it.
I ll let you know If I get stack.

Regards,
LS

lousou76:
If you need any help on that, just drop me a few lines via PM 
Very curious to see what the community is voting for.

Regards Christian

[doc]

lousou76:
If you need any help on that, just drop me a few lines via PM 
Very curious to see what the community is voting for.

Regards Christian

[lousou76]

Looks like I ll be spending the weekend home... 

Ok I ll download the latest svn and see how to make the appropriate changes.

I 've already added the right code and you can now define those startup values on top of the modules/wysigy/modify.php

It will load as requested if more than 2 editors are on the page.

I will now work on the latest svn and have those files ready on a seperate package.
Regards,
LS

@lousou76:
Maybe it is worth while to offer a package based on the latest SVN version, as the release candiate of the next version WebsiteBaker 2.8 will be released soon. Some of the files have changed (especially admin/pages/modify.php should be a candidate).

I will add these options to the top of the file and I will initiate a poll later on today.

This option should be available in the Advanced Settings dialogue of WebsiteBaker. To get an impression on what files needs to be changed for this, have a look on Changeset 929 which adds the possibility to specify the redirect time in ms for sucess messages. One needs to touch all all language files and some core files to add a single value to the settings table.

Regards Christian

[doc]

@lousou76:
Maybe it is worth while to offer a package based on the latest SVN version, as the release candiate of the next version WebsiteBaker 2.8 will be released soon. Some of the files have changed (especially admin/pages/modify.php should be a candidate).

I will add these options to the top of the file and I will initiate a poll later on today.

This option should be available in the Advanced Settings dialogue of WebsiteBaker. To get an impression on what files needs to be changed for this, have a look on Changeset 929 which adds the possibility to specify the redirect time in ms for sucess messages. One needs to touch all all language files and some core files to add a single value to the settings table.

Regards Christian

[lousou76]

doc thanks for helping, I am adding it to the zip right now.

I agree with you Christian, there should be an option for this in the main panel and a limit as you mention for how many editors before this stuff is activated. I will add these options to the top of the file and I will initiate a poll later on today.

Basically I wanted this because most of my pages have more than 3 sections. I like to make small editable sections which do not mess with the rest of the page.

Stefek when the html iframe is shown there is no form to save, that is why I do not show the save button and show only the edit one. I guess it would be nice to leave it there just in case of not clicking in the frame, or using the other mode that displays the textareas instead of these iframes.

Regards,
Lazaros

Hello,

attached a modified /admin/pages/modify.php file which fixes the warnings and the php short tags.

Have tested the stuff but do not really see the benefit as long as you do not add at least 3 WYSIWYG sections on a single page, which I guess is not the case for the majority of the WB users.

What I do not like is the fact, that I have to press the show editor button even if only one WYSIWYG editor is present on a page. Think it would be more convinient to show the editor per default if only one WYSIWYG section is added to a page and show the buttons only if more than X WYSIWYG editors are used at one page. Ideally this option should be configurable via the backend (e.g. option 0, show as usual, 1 toogle if 1 WYSIWYG editor is present, 5 if 5 ore more are present).

@lousou76: May be worth while to initiate a poll to find out if people would like to see this feature in a future WebsiteBaker version or not.

Regards Christian

[Stefek]

What I do not like is the fact, that I have to press the show editor button even if only one WYSIWYG editor is present on a page.

With the latest updat by LouSou there is no need anymore to press the button. Editor opens if you click into the content frame.
I propose to rename it back to "save".

Ideally this option should be configurable via the backend (e.g. option 0, show as usual, 1 toogle if 1 WYSIWYG editor is present, 5 if 5 ore more are present).

Yes. I agree.

@lousou76: May be worth while to initiate a poll to find out if people would like to see this feature in a future WebsiteBaker version or not.

Yes, LouSou.
Please do it.
If you want I will startone in the German Language forum.

Regards,
Stefek

[doc]

Hello,

attached a modified /admin/pages/modify.php file which fixes the warnings and the php short tags.

Have tested the stuff but do not really see the benefit as long as you do not add at least 3 WYSIWYG sections on a single page, which I guess is not the case for the majority of the WB users.

What I do not like is the fact, that I have to press the show editor button even if only one WYSIWYG editor is present on a page. Think it would be more convinient to show the editor per default if only one WYSIWYG section is added to a page and show the buttons only if more than X WYSIWYG editors are used at one page. Ideally this option should be configurable via the backend (e.g. option 0, show as usual, 1 toogle if 1 WYSIWYG editor is present, 5 if 5 ore more are present).

@lousou76: May be worth while to initiate a poll to find out if people would like to see this feature in a future WebsiteBaker version or not.

Regards Christian

[gelöscht durch Administrator]

[Stefek]

I 've updated the zip file. It now opens the editor on the specific section when you click on it.

Cool.

For the stuff with warnings I have no idea.

I really hope that the devs will pick this idea up and integrate this in the next release.
It really speeds up the work on multi-section pages. I literally _dreamed_ about something similar.

Regards,
Stefek

[lousou76]

@Lousou76:
Also check the php.in for the following settings (e.g. xampp/apache/bin/php.ini; remember to restart Apache afterwards).

Code Select Expand

display_errors = On
error_reporting  =  E_ALL

Regards Christian

I couldn't reproduce those notices, but they are definately not fatal.
(I am running this code on redhat with display_errors=on and error_reporting=E_ALL)
The code is running. Something else is wrong.

I 've updated the zip file. It now opens the editor on the specific section when you click on it.

Regards,
LS

[doc]

@Lousou76:
Also check the php.in for the following settings (e.g. xampp/apache/bin/php.ini; remember to restart Apache afterwards).

Code Select Expand

display_errors = On
error_reporting  =  E_ALL

Regards Christian

[Stefek]

Setting the reports to E_ALL gives me - in fact -  warnings.

Notice: Undefined index: template in C:\xampp\htdocs\wb-testu\admin\pages\modify.php on line 60

and

Notice: Undefined variable: block in C:\xampp\htdocs\wb-testu\admin\pages\modify.php on line 129

But the function is running anyway...

Regards,
Stefek

[lousou76]

Hi,

well, there were only 3 files to put in the right place, so yes.
Think problem is error reporting. Setting it to E_ALL I get warnings which break the function.

Regards Christian

That couldn't be right. I have the setting to E_ALL and I get no warning at all.
Could you give us the warnings?

LS

[doc]

Hi,

well, there were only 3 files to put in the right place, so yes.
Think problem is error reporting. Setting it to E_ALL I get warnings which break the function.

Regards Christian

[Stefek]

I used a fresh 2.7 final (no SVN something).

Did you put the files in the correct directories?

Regards,
Stefek

[doc]

Hi,

tested it with WB 2.7 final and error reporting set to E_ALL (Options -> Advanced Settings). The only thing I can see are some warnings and the output of two menu calls from info.php. What WB version is required for testing?

Regards Christian

[lousou76]

Well, I think they both are doable.

I just wonder which css file to use. I must find out in which template the section belongs to and then import it into the current editor's one.

Lets see...

[Stefek]

Hello  LouSou.

Nevermind. This two points I mentiioned above are not really importand.

I have another 2 suggestions:

1) Your Quote:

I could although change the iframe's onclick event and instead of doing nothing it could take you to edit it.
That way you wouldn't even have to click on the "open editor" button.

Yes, I think this is a very handy approach.

2) The CSS.
Now it is just HTML without any Style.
It is possible for you to implement the css-file. Sometimes we create also a so called "editor.css" which renders the HTML in a special way. Else the standard CSS File is applied.

Is this something doable?

Regards,
Stefek

[lousou76]

Thank you! I am glad you liked it!
I really think it should be part of the next release. Pages with many sections take too much time to modify if loading too many editors.

Now about the suggestions,  as I can see,  if you click on the left column links you will go directly to the section you wish to see or edit. We could make it having the editor on there, but we would have to check if they have the editor enabled.

About 2 I am not sure. I guess you mean we should load the section so you can see what you are editing.
I think we are adding too much code with no real need though. Clicking the left link of the section will open the section on a new tab so you can see it. But I always like to be carefull on the labels I use so I know which part I am changing.

Regards,
LS

Hello LouSou!!

Brava!!
Didn't have the time to take a look at this earlier today. I am impressed. Really!

Only 2 Things left:
1) if I am at admin/pages/sections.php?page_id=n and I am selecting one of the sections. Would it be possible to toggle the editor "on"?
2) Creating a new Page it would be great if the editor is also toggled "on".

This are only my suggestions. Maybe I am wrong with Point (1) because sometimes you only want to see the content of the section...

Again. I am impressed. This is very handy and fast.
It should be Part of the next release (with the possibility to turn this function on/off in WB-Settings.

Thanks for picking my Idea up.

Best regards,
Stefek

[Stefek]

Hello LouSou!!

Brava!!
Didn't have the time to take a look at this earlier today. I am impressed. Really!

Only 2 Things left:
1) if I am at admin/pages/sections.php?page_id=n and I am selecting one of the sections. Would it be possible to toggle the editor "on"?
2) Creating a new Page it would be great if the editor is also toggled "on".

This are only my suggestions. Maybe I am wrong with Point (1) because sometimes you only want to see the content of the section...

Again. I am impressed. This is very handy and fast.
It should be Part of the next release (with the possibility to turn this function on/off in WB-Settings.

Thanks for picking my Idea up.

Best regards,
Stefek

[lousou76]

That would be nice too but:

1) I am afraid the images would slow down the edit page (html will load a lot faster)
2) We could have a lot of problems when converting text2image and the final user might see a section differently than it shows on his browser.

I could although change the iframe's onclick event and instead of doing nothing it could take you to edit it.
That way you wouldn;t even have to click on the "open editor" button.

LS

You could try to render these sections with a "text2image" script into a graphic and display that, clicking it would open the editor in/for that section. That would make it a bit more "end user friendly", don't you think?

cheers

Klaus

[kweitzel]

You could try to render these sections with a "text2image" script into a graphic and display that, clicking it would open the editor in/for that section. That would make it a bit more "end user friendly", don't you think?

cheers

Klaus

[lousou76]

Ok I finished it!

I had to add one more file to be able to show content on iframes.
It now shows the source in iframes with click and rightclick disabled and you can use the 'Open Editor' button to enable the editor and go directly to the editing section.

If you liked it the way it was and you want it to show the source textarea when you edit pages instead, you can open the file

/modules/wysiwyg/modify.php and change at the top line where it says

Code Select Expand

$emode = 'iframe'; to

Code Select Expand

$emode = 'none';

Hope you enjoy!

Cheers,
LS